feat: Relocate experimental features settings

dcalhoun commented 1 week ago

Relocate experimental features settings to reside next to debug settings.

Relates to https://github.com/wordpress-mobile/WordPress-Android/pull/21459#issuecomment-2474767835.

Light	Dark

Testing Instructions

Re-test https://github.com/wordpress-mobile/WordPress-Android/pull/21459 in the new location.

Regression Notes

Potential unintended areas of impact Unlikely to impact anything given the narrow focus.
What I did to test those areas of impact (or what existing automated tests I relied on) N/A.
What automated tests I added (or what prevented me from doing so) Deemed unnecessary for the experimental features.

PR Submission Checklist:

[x] I have completed the Regression Notes.
[x] I have considered adding accessibility improvements for my changes.
[x] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing Checklist (strike-out the not-applying and unnecessary ones):

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] Talkback.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] Large and small screen sizes. (Tablet and smaller phones)
[ ] Multi-tasking: Split screen and Pop-up view. (Android 10 or higher)

dangermattic commented 1 week ago

	3 Warnings
:warning:	`strings.xml` files should only be updated on release branches, when the translations are downloaded by our automation.
:warning:	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.

	App Name	WordPress
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21467-f1d467b
	Commit	f1d467b9975386a36e4649defd661d5ea556ea52
	Direct Download	`wordpress-prototype-build-pr21467-f1d467b.apk`

Note: Google Login is not supported on these builds.

wpmobilebot commented 1 week ago

📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.

	App Name	Jetpack
	Flavor	Jalapeno
	Build Type	Debug
	Version	pr21467-f1d467b
	Commit	f1d467b9975386a36e4649defd661d5ea556ea52
	Direct Download	`jetpack-prototype-build-pr21467-f1d467b.apk`

Note: Google Login is not supported on these builds.

nbradbury commented 6 days ago

@dcalhoun Nice job on your first Compose task! One recommendation I have for future work is to avoid putting the ViewModel and the composables inside the activity.

I know there are several places we do that in the app, but it's better to have both the ViewModel and the composables as separate files.

The reason for this is to avoid making the mistake of having the ViewModel "aware" of the activity, and likewise for the composables. That mistake was not made here, but it has been made elsewhere in the app.

sonarcloud[bot] commented 6 days ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 39.49%. Comparing base (e34429a) to head (f1d467b). Report is 46 commits behind head on trunk.

Files with missing lines	Patch %	Lines
...ava/org/wordpress/android/ui/ActivityLauncher.java	0.00%	3 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## trunk #21467 +/- ## ======================================= Coverage 39.49% 39.49% ======================================= Files 2119 2119 Lines 99459 99459 Branches 15285 15285 ======================================= Hits 39277 39277 Misses 56701 56701 Partials 3481 3481 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wordpress-mobile / WordPress-Android