wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

My site more menu button accessibility #21474

Closed nbradbury closed 12 hours ago

nbradbury commented 2 days ago

Fixes #21409

Prior to this PR, the various cards on the My Site tab each had a more menu button with the same content description (simply "More"). This PR corrects that by providing different content descriptions for these cards:

To test, turn on TalkBack and verify those menu buttons have different content descriptions.

dangermattic commented 2 days ago
2 Warnings
:warning: strings.xml files should only be updated on release branches, when the translations are downloaded by our automation.
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 2 days ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21474-035230f
Commit035230f5fb5aeb0809bf5eedf02fa7381b2d2b6e
Direct Downloadwordpress-prototype-build-pr21474-035230f.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 2 days ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21474-035230f
Commit035230f5fb5aeb0809bf5eedf02fa7381b2d2b6e
Direct Downloadjetpack-prototype-build-pr21474-035230f.apk
Note: Google Login is not supported on these builds.
nbradbury commented 13 hours ago

I noted a couple of "cards" that still have buttons solely labeled by "more." We could address those now or sometime later.

@dcalhoun Apologies for missing those two! I've just added a content description to those as well.

sonarcloud[bot] commented 13 hours ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud