wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.99k stars 1.33k forks source link

Stop using restricted APIs in WPMainNavigationView #21482

Open nbradbury opened 6 hours ago

nbradbury commented 6 hours ago

Fixes #21079

We've been using restricted APIs in WPMainNavigationView, but it turns out this was never necessary. This PR drops the usage of the restricted APIs.

To test, simple ensure the bottom navigation bar looks and works as expected, including badging. To force badging on the notifications tag, change this function to always set the badge.

sonarcloud[bot] commented 6 hours ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

wpmobilebot commented 5 hours ago
Jetpack📲 You can test the changes from this Pull Request in Jetpack by scanning the QR code below to install the corresponding build.
App NameJetpack Jetpack
FlavorJalapeno
Build TypeDebug
Versionpr21482-770fea9
Commit770fea9cea90b3082ce666c755050c97e0c64601
Direct Downloadjetpack-prototype-build-pr21482-770fea9.apk
Note: Google Login is not supported on these builds.
wpmobilebot commented 5 hours ago
WordPress📲 You can test the changes from this Pull Request in WordPress by scanning the QR code below to install the corresponding build.
App NameWordPress WordPress
FlavorJalapeno
Build TypeDebug
Versionpr21482-770fea9
Commit770fea9cea90b3082ce666c755050c97e0c64601
Direct Downloadwordpress-prototype-build-pr21482-770fea9.apk
Note: Google Login is not supported on these builds.
dangermattic commented 5 hours ago
2 Warnings
:warning: View files have been modified, but no screenshot or video is included in the pull request. Consider adding some for clarity.
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger