wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.95k stars 1.31k forks source link

Add Lint check for attachBaseContext(context) #7460

Open AmandaRiu opened 6 years ago

AmandaRiu commented 6 years ago

PR #7413 added a new requirement that any new Activity that requires localization must include the following:

@Override
protected void attachBaseContext(Context newBase) {
      super.attachBaseContext(LocaleManager.setLocale(newBase));
}

Since using a BaseActivity in the past led to some issues, it was decided to add the method directly to the activity and has been recommended that we create a lint check to make sure it is done in the future. Opened this ticket to start the discussion around adding this lint check.

cc: @aforcier @maxme - WDYT?

stale[bot] commented 4 years ago

This issue has been marked as stale because:

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority (cc @designsimply).

dangermattic commented 1 month ago

Thanks for reporting! 👍