wordpress-mobile / WordPress-Android

WordPress for Android
http://android.wordpress.org
GNU General Public License v2.0
2.96k stars 1.31k forks source link

Post List: Update copy/text of SnackBar messages #9769

Open malinajirka opened 5 years ago

malinajirka commented 5 years ago
oguzkocer commented 4 years ago

Copy: When a published post has local changes and is published, snackbar copy should be Post updated button: View

@jd-alexander and I looked into this one, but as far as we can tell there is no easy/good way to do this. The way we understand the flow working is:

  1. We mark a post to be published in the DB by setting its status to PUBLISHED
  2. Then the UploadService takes care of uploading it to the remote by using the push post action in FluxC
  3. Then we get a callback from FluxC, but that callback doesn't (and can't) have the information about the previous status of the post. It can't have the previous status, at least not as is, because we mark the post's status as PUBLISHED before the FluxC even knows that it'll be updated.

This change is probably just a nice to have, so unless we are missing something, it's probably not worth doing it.

malinajirka commented 4 years ago

👍 I was worried it might be the case. This is a completely valid outcome, thank you both for looking into it;). As you said, it's just a nice to have feature.