search

wordpress-mobile / WordPress-Editor-Android

⛔️ [DEPRECATED] A reusable Android rich text editor component.
GNU General Public License v2.0
188 stars 50 forks source link

API19+ autocorrect issues #157

Open aforcier opened 9 years ago

aforcier commented 9 years ago

This is a master list of issues caused by autocorrect/autocomplete in the API 19+ Chromium WebView:

Apparently solved (may have missed edge cases)

Solved

These happen consistently on stock Android devices, with the default system soft keyboard.

Notes on variations:

bummytime commented 9 years ago

Formatting glitches with blockquotes: https://cloudup.com/cN0k8O4nIXV (ref: PR #153)

Testing on a Samsung S6 (API21) and I am not seeing this behavior.

aforcier commented 8 years ago

Noticing an autocorrect bug when pressing backspace on a new line with whitespace right after exiting a blockquote. (API23 Nexus 5X)

rachelmcr commented 8 years ago

I noticed that the last word of an image caption is duplicated if you backspace up to the caption and then start typing: https://cloudup.com/c2TqFDbohIh

Tested in Nexus 9, Android 6.0.1 (API23), app v. alpha-6. Only happens when autocorrect is enabled.

aforcier commented 8 years ago

Formatting glitches with blockquotes: https://cloudup.com/cN0k8O4nIXV (ref: PR #153 Issue #159)

Can't reproduce this one anymore, almost certainly fixed by the p -> div change.

aforcier commented 8 years ago

Re: word duplication (bullet #3 above, and Rachel's comment about image captions), all cases seem to involve:

  1. Entering text in an element that's not a div
  2. Switching (e.g. by backspace) from a div element to a non-div element

This was partially fixed in https://github.com/wordpress-mobile/WordPress-Editor-Android/pull/334, by switching from p as the paragraph separator to div (for normal paragraphs with no formatting), and with https://github.com/wordpress-mobile/WordPress-Editor-Android/pull/358 (for pasting and general blockquotes). Less common cases like captions still exist, however, and have to be individually fixed.

aforcier commented 8 years ago

One case of autocorrect glitching occurs when exiting a blockquote, typing, and backspacing after space:

aurocorrect-bug-after-blockquote

The same also happens after lists.

aforcier commented 8 years ago

I'm only able to reproduce the bug above on an API23 device and an API22 emulator, - API19 and 21 emulators don't exhibit the bug.

aforcier commented 8 years ago

Opened a new issue for above bug and updated initial comment: https://github.com/wordpress-mobile/WordPress-Editor-Android/issues/367.

aforcier commented 8 years ago

Posts beginning with blockquotes on API23+ can have the blockquote stripped by autocorrect (https://github.com/wordpress-mobile/WordPress-Editor-Android/issues/385)

This was fixed in #399, updated OP.

aforcier commented 8 years ago

Words are sometimes duplicated, the full cause is still under study (an example can be seen in the blockquote glitch video)

I think all cases of this have been fixed, I haven't encountered this issue in a long while. I've updated the OP and moved it to a 'Apparently solved' group, since it's possible it might still occur in a rare edge case.

aforcier commented 8 years ago

Applying a style (e.g. bold, italics) while in the middle of typing a word (with visible suggestions) does not work (#123)

This was fixed in #427, updated OP.

rachelmcr commented 8 years ago

If you have a formatted word followed by a misspelled, unformatted word, the misspelled word will get the formatting from the previous word when it's autocorrected:

  1. With autocorrect enabled on your device, open the editor
  2. Tap the italics button to enable it, type a word and a space, and tap the italics button to disable it again
  3. Misspell the next word you type
  4. Add a space. Result: The word is autocorrected and gets the formatting from the previous word.

Reported originally on Moto g, WPAndroid alpha-16. Tested and confirmed on Nexus 9, Android 6.0.1, WPAndroid alpha-16. h/t Zandy for the report.