Issue #401: Blockquote toggle off issues in new posts

wordpress-mobile / WordPress-Editor-Android

⛔️ [DEPRECATED] A reusable Android rich text editor component.

GNU General Public License v2.0

188 stars 50 forks source link

Closed aforcier closed 8 years ago

aforcier commented 8 years ago

Fixes #401, correcting the behavior when toggling off an empty blockquote when the post is otherwise empty.

To test, launch editor with empty post and toggle blockquote on and then off again without typing anything.

On API19 and below, toggling the blockquote off now actually works, removing the empty blockquote
On all API levels, toggling the blockquote off no longer leaves an empty newline behind, so that now the placeholder shows up again right away

cc @maxme

maxme commented 8 years ago

On all API levels, toggling the blockquote off no longer leaves an empty newline behind, so that now the placeholder shows up again right away

I still get the empty new line on API 23. (and API 21)

aforcier commented 8 years ago

I still get the empty new line on API 23. (and API 21)

Fixed in 5664496, the cause was overzealous refactoring 😅.

maxme commented 8 years ago

Looks good! :shipit: