Sync with wpandroid - Githubissues

wordpress-mobile / WordPress-Editor-Android

⛔️ [DEPRECATED] A reusable Android rich text editor component.

GNU General Public License v2.0

188 stars 50 forks source link

Sync with wpandroid #474

Open malinajirka opened 4 years ago

jkmassel commented 4 years ago

Hey @malinajirka – I'm not sure how to meaningfully review this – if it's just a sync it's probably ok? Do we have a way of verifying consistency between the two repos to ensure the sync worked right?

malinajirka commented 4 years ago

Hi @jkmassel ! I asked a very similar question some time ago - you can find Alex's answer here.

In summary

verify that the PR was created with git v2.19.2 or older (history is not broken)
if you want to be extra careful, perform the merge yourself and compare the changes - I hope it's not necessary :D

malinajirka commented 4 years ago

Thanks for the review @jkmassel! Nice catch - I've removed the empty files in 4fbef0f.