search

wordpress-mobile / WordPress-Editor-Android

⛔️ [DEPRECATED] A reusable Android rich text editor component.
GNU General Public License v2.0
188 stars 50 forks source link

Media: Simple image editing would be useful #89

Open bummytime opened 9 years ago

bummytime commented 9 years ago

Original issue: https://github.com/wordpress-mobile/WordPress-Android/issues/342

When adding an image to a post either by capturing from within the WP editor or when browsing from the photo library, you can't crop or change the orientation. A real life scenario:

  1. I snapped a couple of photos of things my daughter had hand-written.
  2. They're in the photo library now.
  3. I upload to a post.
  4. Oops, they're sideways.
  5. I try to rotate within the WP app with no luck.
  6. I go into the photo library and rotate and crop.
  7. Now I have a duplicate image.
  8. What's worse, if I left the post mid-composition to edit the photos, my changes to the post are lost unless I remembered to save a draft first.
  9. Now I reinsert into the post and publish.

If there's an API for doing even just basic rotating and cropping from within the app (say from the screen you get when you double-click an image within the editor), it'd make for a much improved workflow and reduce the likelihood of data loss.

rachelmcr commented 8 years ago

I tested this in the new editor and noticed a few things:

  1. I took a few photos on my device.
  2. They're in the photo library on the device.
  3. I upload to a post.
  4. I didn't have any issues with image orientation, with both vertical and horizontal photos, but I could imagine wanting to do some basic cropping or other editing in any case.
  5. I try to edit within the WP app, but no luck. I can only edit the image settings, not the image itself.
  6. I go into the photo library and rotate and crop.
  7. Now I have to upload a duplicate image (although I can delete the duplicate from the Media section of the app).
  8. Alternately, I can go to my media library in a web browser and edit the image there. However, the media library in the editor doesn't refresh with my edits, so I can't immediately re-add the edited image to my post.
  9. If I leave the post mid-composition to make those edits, my changes are saved in a local draft (no data loss).

Given that there aren't any issues with data loss, and I didn't have any issues with images uploading with the wrong orientation, I don't see any pressing need to add editing features. That said, some basic editing would be a nice-to-have as a future enhancement for images that are already uploaded, or for images that you capture from within the editor.

Tested in Nexus 9, Android 6.0.1, alpha-4.