Preview post consistency

wordpress-mobile / WordPress-Editor-iOS

⛔️ [DEPRECATED] A reusable iOS rich text editor component.

GNU General Public License v2.0

1.06k stars 210 forks source link

Preview post consistency #180

Closed meremagee closed 9 years ago

meremagee commented 10 years ago

Preview post should always take you to themed preview (what post would look like published).

Currently behavior:

new post: hit preview > our custom styled reader view
published post: hit preview > normal, published view preview in blog theme

bummytime commented 10 years ago

@meremagee I can dig that. A couple of things:

I am assuming if the device's connectivity is spotty, we will need to default to the simple preview.
Are you saying that any new post created on device needs to be automatically created server-side? At present, we are just creating a local copy and only pushing it to the server if the user saves it as a draft or publishes it. (If it is a local copy we don't have access to the users Wordpress theme to render the post appropriately)

meremagee commented 10 years ago

The WYSIWYG editor itself seems like as much of a "simple preview" as our current implementation of the simple preview (albeit without displaying tags inline).

maybe hitting preview while editing "saves" and renders on server-side at that time. If connection is too low, we give a nice error msg. I don't think this would be much of a problem since their low connectivity would likely block publishing as well.

@thianhlu thoughts?

thianhlu commented 10 years ago

So the current implementation is similar to what we have production. If the post is Published, it then can render the themed preview, if not it gives the simple one.

In 4.5, let's explore a way to render a themed one before a user publishes.

meremagee commented 10 years ago

Related: if you edit a published post, adding content, then hit preview again, the updates don't display in the server-rendered content.

bummytime commented 9 years ago

@meremagee so what are the final todos for this issue? I am not sure...

meremagee commented 9 years ago

Per slack discussion...

Because themed previews will always take a round trip to the server, we have a few options:

we can bundle "preview" & "save" so that we always save and fetch a copy of the latest edits from the server before we preview (this is what the web interim editor does). This would necessitate a good enough connection to make the round trip.
we keep it snappy and local with styling that matches the Reader (which strips themes and renders everything uniformly). I have notes on the differences between the preview and reader styling if need be. This would work on a poor connex.
we keep it snappy and local and don't change the default. This would work on a poor connex.

Regardless, since it's "fine" as is, pushing this to the next release so @thianhlu can make the styling decision.

bummytime commented 9 years ago

orca-yes

thianhlu commented 9 years ago

No action, closing since details are in #153