Fix for HTML mode switching hack

bummytime commented 8 years ago

Fixes #777

Updates the hack that was originally used to fix an issue where the format bar would not resize properly when the editor was rotated or resized. Now, instead of switching modes, we blur and refocus the field which updates the input accessory view and forces it to resize properly. Doing this allows media to upload without being interrupted.

Things to test:

Run the app on an Air2 or iPad Pro. Use multitasking in various ways...make sure the format bar resizes. Upload media while doing this and make sure it is not interrupted.
Run the app various iPhones....make sure the format bar resizes. Upload media while doing this and make sure it is not interrupted.
Upload media while rotating the device.

/cc @SergioEstevao

SergioEstevao commented 8 years ago

One last question, do we really need to do the dance of resign/becomeFirstResponder on the source code view? In there we are using the standard UITextView and no hack for the acessoryInputView so should the rotation work by itself?

bummytime commented 8 years ago

@SergioEstevao Unfortunately, yes:

SergioEstevao commented 8 years ago

ok then so :shipit:

wordpress-mobile / WordPress-Editor-iOS

Fix for HTML mode switching hack #778