wordpress-mobile / WordPress-Editor-iOS

⛔️ [DEPRECATED] A reusable iOS rich text editor component.
GNU General Public License v2.0
1.06k stars 210 forks source link

Replace Open Sans with system fonts #780

Closed koke closed 8 years ago

koke commented 8 years ago

See: wordpress-mobile/WordPress-iOS#4895 Cc: @mattmiklic Needs Review: @bummytime

mattmiklic commented 8 years ago

Everything is looking good to me here so far in a quick overview; will continue to test in real-world use.

bummytime commented 8 years ago

@koke if @mattmiklic is happy, I am happy. :-) Seriously, everything looks ok form my perspective, so if y'all are good with it :shipit:

SergioEstevao commented 8 years ago

@mattmiklic the only question that I have here, is that on the images and videos when an upload fails we where showing a message saying "failed because of ....", and after an upload is done we where showing a "Edit" text when tapping on the image. both of these where using Open San and now they where replaced for the system font (SF). Should we use that or Merriweather?

mattmiklic commented 8 years ago

@SergioEstevao Both of those should be in system fonts. Thanks for checking!