Issue/752 upload images missing edit fields - Githubissues

wordpress-mobile / WordPress-Editor-iOS

⛔️ [DEPRECATED] A reusable iOS rich text editor component.

GNU General Public License v2.0

1.06k stars 210 forks source link

Issue/752 upload images missing edit fields #786

Closed SergioEstevao closed 8 years ago

SergioEstevao commented 8 years ago

Closes #752 Refs https://github.com/wordpress-mobile/WordPress-iOS/issues/4942

How to test:

On the Editor sample project, insert an image
After the upload is finished, switch to source code mode
Check if the image size attributes width and height are set.
Check if the class attributes are set for align, size and wp-image-XXX are set.
You can also use this branch https://github.com/wordpress-mobile/WordPress-iOS/tree/editor/test_media_attributes to test it on the main app.

Needs Review: @bummytime

bummytime commented 8 years ago

@SergioEstevao Ok, I tested this pretty thoroughly. The attribs are being set properly and images behave as expected in calypso and wp-admin. Code is square too. Nice fix!

:shipit: