wordpress-mobile / WordPress-Editor-iOS

⛔️ [DEPRECATED] A reusable iOS rich text editor component.
GNU General Public License v2.0
1.06k stars 209 forks source link

Added checks for delegate methods and updated doc comments #891

Closed bummytime closed 7 years ago

bummytime commented 7 years ago

This PR:

To test:

  1. Build and run the Editor demo. Verify everything works and doc warnings are gone.
  2. Build and run WPiOS on this branch. Verify everything works.

@elibud would you mind reviewing?

diegoreymendez commented 7 years ago

Unfortunately stripping Javascript from HTML may not be very trivial.

Here's an old personal attempt to solve a similar issue, that simply turned off an old post-creating mechanism in the App, instead of stripping JS code.

Sorry I didn't provide this information before but I only remembered about it now.

I'll check if our endpoint is actually taking care of stripping the JS code, since that would make this issue mostly cosmetic (ie: client-side only).

bummytime commented 7 years ago

ty @elibud and @diegoreymendez !