wordpress-mobile / WordPress-FluxC-Android

WordPress Network and Persistence layer based on the Flux architecture
GNU General Public License v2.0
57 stars 37 forks source link

New dimensions field #3093

Closed atorresveiga closed 2 months ago

atorresveiga commented 2 months ago

Description

The new Shipping extension introduced a new field for Custom package dimensions: dimensions. This PR adds this new field to the CustomData class and uses it when creating a CustomPackage, so we don't lose the package information and prevent a crash when the CustomPackage dimensions field is empty. Additionally to this changes I also updated the default value we were using for dimensions now instead of the empty string "" we will use "0 x 0 x 0", so that the app won't crash in case of a custom package with empty dimensions.

Testing

It is best to test these changes using the Woo PR