wordpress-mobile / WordPress-FluxC-Android

WordPress Network and Persistence layer based on the Flux architecture
GNU General Public License v2.0
58 stars 37 forks source link

[Deps] Add Back EventBus Android Dependency #3100

Closed ParaskP7 closed 2 months ago

ParaskP7 commented 2 months ago

Depends On:

Description

This PR adds back the main EventBus dependency, which is Android related.

This dependency was incorrectly removed and replaced by its corresponding eventbus-java transitive dependency, assuming that is not required. However, after further testing it was revealed that this parent eventbus dependency, which is actually android specific is indeed necessary. If it is not provided on the classpath then an app will crash with the below runtime exception:

java.lang.RuntimeException: Unable to create application xyz: java.lang .RuntimeException:
It looks like you are using EventBus on Android, make sure to add the "eventbus" Android
library to your dependencies.

For more info see:

Testing Instructions

  1. Tooling:
    • Run the ./gradlew buildHealth task and verify that there is no unused related advise related to eventbus.
  2. Testing:
    • Smoke test the FluxC Example app, try out all available screens and functionality. Verify everything is working as expected.
    • Also, if you want to be thorough about reviewing the changes, you could quickly smoke test, either the JP/WPAndroid and/or WCAndroid, with this version of FluxC, or via composite builds, and see if it works as expected.