wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

Add scan QR code optional CTA to LoginMagicLinkSentImprovedFragment #102

Closed JorgeMucientes closed 1 year ago

JorgeMucientes commented 1 year ago

Description

Adds new CTA to scan QR code from magic link sent screen. The goal was to add the least possible changes in the auth lib to ensure that backwards compatibility is not broken in case any other apps are using this screen.

Most of the changes are done in this PR inside WooCommerce Android repository. Nothing to test in this PR.

EDIT

After @hichamboushaba suggestion I removed LoginMagicLinkSentImprovedFragment from this library and migrated it to WooCommerce Android repo. So this PR just does that -> remove LoginMagicLinkSentImprovedFragment

Screenshots

ScanQrCta

hichamboushaba commented 1 year ago

@JorgeMucientes A suggestion, since we are planning on making more changes to this screen, why not just move it completely to Woo? I suggested this to @0nko before, and we decided to skip it because the work was already done, but now I see we are doing more changes, then maybe it's simpler to copy the code of the improved magic link screen and drop it in Woo, then we can get rid of the inheritance which makes code harder to reason about.

JorgeMucientes commented 1 year ago

Makes sense @hichamboushaba. We are sure WordPress is not using this right? I'll get to it!

hichamboushaba commented 1 year ago

We are sure WordPress is not using this right?

I looked at the WPAndroid repo now, and I confirm it's not used anywhere.

JorgeMucientes commented 1 year ago

Ready for review @hichamboushaba @0nko 🙏🏼