wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

Update `minSdkVersion` (from `21` to `24`) #103

Closed ParaskP7 closed 1 year ago

ParaskP7 commented 1 year ago

This PR upgrades Login to minSdkVersion to 24. This has been unblocked because:


As part of this minSdkVersion = 24 upgrade the below changes were also applied in order to fix any additional warnings that this change brought-up:

Warnings Resolution List:

  1. Resolve obsolete sdk int lint warning for res values v23.
  2. Remove unnecessary duplicate v27 theme login flow config.

Dependency Config List:

  1. Rename kotlin ktx to androidx core version.
  2. Extract all dependency version to root build gradle.
  3. Add androidx prefix to app compat version.
  4. Move androidx app compat/core and dagger versions to main group.

Dependency Update List:

  1. Update robolectric to 4.9.

PS: @ovitrif @atorresveiga I added you as the main reviewers, that is, in addition to the @wordpress-mobile/apps-infrastructure team itself, but randomly, since I just wanted someone from both, the WordPress and Woo Commerce teams, to sign-off on that change for WPAndroid and WCAndroid alike.


Testing instructions

ParaskP7 commented 1 year ago

πŸ‘‹ @ovitrif !

Thank you so much for reviewing, testing and catching this issue, you are a hero! πŸ₯‡

Overall the changes LGTM, I've left a comment for an issue I've noticed on the status bar color in WP-Android.

Replied here. πŸ™‡ πŸ₯‡ πŸ™

I understand from https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2563#discussion_r1020091519 that you may be reviewing & possibly change the approach with gradle.ext... versions in settings.gradle.

Yes, exactly, thus, please let do the merging part, that is, when I figure-out how to best progress with the gradle.ext thingie... πŸ€”

Please let me know when that's decided, as well as the resolution for the status bar color is handled, so I can give this another pass.

It is now ready for another pass, please take another look when possible, no rush! πŸ’―

ParaskP7 commented 1 year ago

πŸ‘‹ @ovitrif !

I've tested again the login flow in WP Android and the issue with the statusBar is resolved as expected πŸ₯‡ .

A BIG thank you Ovi! πŸ™‡ πŸ™‡ πŸ™‡

ParaskP7 commented 1 year ago

Thank you so much for the review and testing @atorresveiga , you are awesome! πŸ™‡ πŸ₯‡ πŸ’―