Closed ParaskP7 closed 1 year ago
π @ovitrif !
Thank you so much for reviewing, testing and catching this issue, you are a hero! π₯
Overall the changes LGTM, I've left a comment for an issue I've noticed on the status bar color in WP-Android.
Replied here. π π₯ π
I understand from https://github.com/wordpress-mobile/WordPress-FluxC-Android/pull/2563#discussion_r1020091519 that you may be reviewing & possibly change the approach with gradle.ext... versions in settings.gradle.
Yes, exactly, thus, please let do the merging part, that is, when I figure-out how to best progress with the gradle.ext
thingie... π€
Please let me know when that's decided, as well as the resolution for the status bar color is handled, so I can give this another pass.
It is now ready for another pass, please take another look when possible, no rush! π―
π @ovitrif !
I've tested again the login flow in WP Android and the issue with the statusBar is resolved as expected π₯ .
A BIG thank you Ovi! π π π
Thank you so much for the review and testing @atorresveiga , you are awesome! π π₯ π―
This PR upgrades Login to
minSdkVersion
to24
. This has been unblocked because:WPAndroid
was already onminSdkVersion = 24
, for some time now (see here).WCAndroid
has been recently upgraded tominSdkVersion = 24
as well (see here).As part of this
minSdkVersion = 24
upgrade the below changes were also applied in order to fix any additional warnings that this change brought-up:Warnings Resolution List:
Dependency Config List:
Dependency Update List:
PS: @ovitrif @atorresveiga I added you as the main reviewers, that is, in addition to the @wordpress-mobile/apps-infrastructure team itself, but randomly, since I just wanted someone from both, the
WordPress
andWoo Commerce
teams, to sign-off on that change for WPAndroid and WCAndroid alike.Testing instructions
WordPress
orWoo Commerce
apps, with this version ofLogin
, and see if it works as expected.WordPress
orWoo Commerce
apps, with this version ofLogin
, on Android 5 (API 21/22
) and Android 6 (API 23
) devices and verify that you can't (see API Levels).