search

wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

[Woo] Disable XMLRPC discovery in site address screen #109

Closed hichamboushaba closed 1 year ago

hichamboushaba commented 1 year ago

This PR is needed for https://github.com/woocommerce/woocommerce-android/issues/8282

When REST API is supported, we will be handling login using Cookie Nonce authentication, and in this case the XMLRPC discovery is not needed, and the login should work even when XMLRPC is disabled, so we don't need its discovery checks.

Check the WCAndroid PR for more information.

JorgeMucientes commented 1 year ago

Code changes look good @hichamboushaba! Tested that everything works as expected as part of this PR review.

Well done! :shipit: