wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

[Compile Warnings As Errors] Resolve Warnings & Enable All Warnings as Errors #117

Closed ParaskP7 closed 10 months ago

ParaskP7 commented 10 months ago

This PR resolves/suppresses all warnings for all modules and then enables all warnings as errors as the default for this project (776e3ea2fe461ffea74bccb65da66d5a11dc601b).

PS: This is done just to restrict further Kotlin related warnings to creep into this repo and with it to also enable future Kotlin updates, for example see below warning that would have made the Kotlin 1.7 update a bit more in the future:

Non exhaustive 'when' statements on enum will be prohibited in 1.7, add 'XYZ' branches or 'else' branch instead


Warnings Resolution List:

  1. Resolve to lower case deprecated warning

Warnings Suppression List:

  1. Suppress deprecated warning

Lint Restructure List:

  1. Change lint to lint release check

Test Restructure List:

  1. Change test to test release check

To test

  1. There is nothing much to test here (if not all, most of the deprecated warnings were suppressed).
  2. Verifying that all the CI checks are successful should be enough.
ParaskP7 commented 10 months ago

Thank you for reviewing and testing this @oguzkocer , you rock! 🙇 ❤️ 🚀