search

wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

Use Gravatar SDK dependency #134

Closed maxme closed 4 weeks ago

maxme commented 3 months ago

cc @hamorillo

wzieba commented 3 months ago

hi @maxme ! I've allowed myself to push https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/pull/134/commits/eeea07c0f47772dbac50b851d324e0d6d292832e to test and showcase usage of artifact stored on S3.

The version now is <PR_number>-<commit-hash> but later we'll adjust to the desired version via Git tag.

maxme commented 3 months ago

@wzieba no problem, I'll update it again with the right version when your PR is merged in trunk on the other side.

hamorillo commented 4 weeks ago

I tried both with a hash reference (134-fbddbe084f24fafd0dc299667674a822bdd9626d) and a composite build but I get a build error since gravatar-0.2.0 cannot be retrieved 🤔

I guess you are using the trunk branch of WPAndroid. You can test it with this branch. The problem is that it's not looking for the library in the right place. We need these changes for that.

antonis commented 4 weeks ago

I guess you are using the trunk branch of WPAndroid. You can test it with this branch. The problem is that it's not looking for the library in the right place. We need these changes for that.

That's correct. Thank you for pointing me to this branch @hamorillo 🙇 I'll retest with that. Are there specific changes I should look for or just a sanity of the functionality?

hamorillo commented 4 weeks ago

The changes are basically that we are using the new Gravatar SDK to load the avatars and generate the URLs so, I would say a sanity check paying attention that you can see the avatars as expected everywhere 🙂.

maxme commented 4 weeks ago

I reverted all the build file changes that felt unnecessary. I get a weird compiling error on my machine when I have WPAndroid setup with WPLogin-Flow and Gravatar-SDK as source dependencies. I can build WPLogin-Flow alone fine though...

maxme commented 4 weeks ago

Cool thanks everyone for testing, I'll merge this one.

What's the process to publish a new WordPress-Login-Flow-Android release?

antonis commented 3 weeks ago

Thank you for your work on this @maxme 🙇

What's the process to publish a new WordPress-Login-Flow-Android release?

My understanding is that we just need to push a tag and create a new release. When the CI takes care of the rest.

We also need to merge the changes on the WPAndroid/Woo clients to avoid any breakages.