search

wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

Google login fix #27

Closed planarvoid closed 4 years ago

planarvoid commented 4 years ago

This merges the changes already in WPAndroid into the login library - https://github.com/wordpress-mobile/WordPress-Android/pull/10523

Do the other commits feel right? The only change I haven't done is the Jitpack update

malinajirka commented 4 years ago

Thanks @planarvoid! I haven't tested the functionality as I assume it was tested in the WPAndroid PR. I've only checked that the correct version of git was used.

One question though: Do you think this change might also fix - https://github.com/wordpress-mobile/WordPress-Login-Flow-Android/issues/7 ?

malinajirka commented 4 years ago

cc @AmandaRiu @0nko You might want to consider merging this fix into Woo.

AmandaRiu commented 4 years ago

Thanks @malinajirka, will do.

planarvoid commented 4 years ago

@malinajirka I think it might fix both (or neither if the issue was somewhere else :-) )