Closed jd-alexander closed 4 years ago
Hey, @jd-alexander 👋 Thanks for the PR! I'm not really sure how to test it tho :) Since it's a subtree, I assume it should already be in the main WordPress module, but I don't see the changes there. I see changes from other commits (which I assume people forgot to push to this repo after implementing it in the main WordPress module).
Hey @khaykov 😄 So I just read some comments in Slack about how subtree updates should be made. I first pushed another PR but closed it when I saw the comment by the bot about pushing commits to the subtree. I will reopen & update it and ping you for another review. So to be clear when a change is made in the subtree project both the WP Android PR and the PR in the subtree repo is merged right?
Thanks! I have yet to touch subtrees, but my understanding is that yes, first we create PR towards WP Android, and as bot suggested we create PR towards this repo. And merge them about same time.
Fixes #10510
To test: Use this PR
This fix solves the issue partially because when the device goes to sleep and wakes up it still does the announcement of the terms of service text twice. Nonetheless, we have stopped the initial double announcement so it's worth merging this in until another solution is found.
PR submission checklist:
[x] I have considered adding unit tests where possible.
[x] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.