Closed renanferrari closed 3 years ago
@renanferrari renanferrari requested review from khaykov, planarvoid and AmandaRiu and removed request for khaykov and planarvoid 3 days ago
Github got confused and I'm not sure whether I should review this PR or not :-). It's in the list of my "Review requests" but I'm not listed as a "Reviewer". Is @AmandaRiu enough @renanferrari ?
Sorry for the confusion, @planarvoid! I had initially requested a review from you and @khaykov but then I talked to the Woo team and decided it was better to leave it to @AmandaRiu, as these changes are most relevant to them.
@renanferrari did an unofficial review of the changes as they pertain to woo-mobile and all looks good. It will be some work for sure, but thanks to you it will be less work 😄. Removing myself as a reviewer since I'm not officially reviewing this PR as discussed in Slack.
@AmandaRiu Thank you! Your "unofficial review" was actually the only thing pending for this PR, as everything else was already tested in WPAndroid 🙂 Since it also looks good on your side, I'm gonna go ahead and merge it.
This PR merges the changes from the Unified Login & Signup project in WPAndroid.
Here's a list of all included PRs:
Functional changes
UI changes
Event tracking changes
The most impactful changes are the ones related to the UI, as both the theme and styles used by the library got a major overhaul. Those changes were reviewed by both WordPress and WooCommerce teams at the time.
Here's a summary of the main breaking changes to watch out for:
LoginListener
was updated accordingly.LoginAnalyticsListener
was updated accordingly.LoginEmailFragment
is the only screen that has kept both its old and new layouts, which can be switched by using theshouldUseNewLayout
flag.