Shorter sign up - remove Send Link by email screen

wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android

GNU General Public License v2.0

14 stars 3 forks source link

Shorter sign up - remove Send Link by email screen #51

Closed ParaskP7 closed 3 years ago

ParaskP7 commented 3 years ago

Fixes WordPress-Android#13971 Related WordPress-Android#14025 Relates WordPressAuthenticator-iOS#574

This PR removes the below intermediate Sign Up screen.

ℹ️ For more info please follow up on the Fixes and Relates PRs.

oguzkocer commented 3 years ago

I am going to leave the review to @renanferrari since he already has context about the changes.

ParaskP7 commented 3 years ago

Many thanks @renanferrari ! 🙏

PS: Apologies for keep adding you as a reviewer to there PRs @oguzkocer . I do that so that you are away of any manual PR that is added to the repo, it is not meant for you to review it per se. Maybe next time I should just mention you instead of adding you as a reviewer and that might help the other reviewer pick it up faster (without assuming that it might get picked-up by the other reviewer).

🙏

oguzkocer commented 3 years ago

Thanks @ParaskP7, but I don't need to keep track of the manual changes. Feel free to ping me with them, but I just thought you should know that it's not necessary.

ParaskP7 commented 3 years ago

Cool, thanks for letting me know @oguzkocer ! I will stop pinging you on those going forward. 🙏