search

wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

Onboarding Improvements: Extract Or Layout #60

Closed ParaskP7 closed 2 years ago

ParaskP7 commented 2 years ago

This PR extracts the or layout to be later on easily reused. On the newly created shared login_or_layout bottom and top padding were added based on its overall usage. This way, every client that is to be using this newly created shared login_or_layout will conform to its now defined standards.

Note: As part of this change the 6dp login layout layout_marginBottom was replaced by the inner 8dp or layout paddingBottom and paddingTop. The paddingTop change is irrelevant since the login_email_screen layout will anyway adjust that automatically. However, the 'paddingBottom' change will have a diff of 2dp. This change can be also considered as negligible, since it is almost unnoticed.

ParaskP7 commented 2 years ago

👋 @ashiagr !

Thanks so much for this review! 🙏

Thanks for extracting "or" layout 🙏. Everything looks good code-wise. I'll leave the decision on @osullivanchris about the bottom 2dp extra padding. Also, let's wait for the CI issue to be resolved. Feel free to merge thereafter.

Yes, before I merge this PR I'll first incorporate this change within WordPress-Android#15036, using a hash version, get an approval from @osullivanchris and then move forward.

ParaskP7 commented 2 years ago

👋 @ashiagr !

A quick update from my side.

Yes, before I merge this PR I'll first incorporate this change within WordPress-Android#15036, using a hash version, get an approval from @osullivanchris and then move forward.

After getting the 👍 from @osullivanchris on the Login Email screen and the Or Layout above the Google Sign-In button, see here, I am now going to proceed with merging this PR.