This PR updates FluxC to 1.23.0 which is published to S3. It updates org.wordpress:lint to 1.1.0 which fixes a warning. It also simplifies the README because we no longer have subtrees in WPAndroid & WCAndroid projects. I deliberately made the instructions very simple so it won't be outdated easily.
There are two changes that might be worth explaining:
Removal of project.hasProperty("fluxCVersion") check for fluxc dependency declaration
Removal of exclude group instructions from README
Both of these changes were made for the same reason. Since the project is no longer a subtree, the client's FluxC version is irrelevant to this library - at least for its release. If there is a conflict, it's up to the clients to address them in their own build files.
Furthermore, FluxC is added as a transitive dependency (implementation) to the project. So, when Gradle finds the FluxC dependency in the client project as a regular dependency, it should always pick that over the transitive dependency if the dependency declaration matches. Meaning the group and module information are the same for each dependency. If they are brought as different dependencies, it will result in duplicate class error.
This PR updates FluxC to
1.23.0which is published to S3. It updatesorg.wordpress:lintto1.1.0which fixes a warning. It also simplifies the README because we no longer have subtrees in WPAndroid & WCAndroid projects. I deliberately made the instructions very simple so it won't be outdated easily.There are two changes that might be worth explaining:
project.hasProperty("fluxCVersion")check for fluxc dependency declarationexclude groupinstructions from READMEBoth of these changes were made for the same reason. Since the project is no longer a subtree, the client's FluxC version is irrelevant to this library - at least for its release. If there is a conflict, it's up to the clients to address them in their own build files.
Furthermore, FluxC is added as a transitive dependency (
implementation) to the project. So, when Gradle finds the FluxC dependency in the client project as a regular dependency, it should always pick that over the transitive dependency if the dependency declaration matches. Meaning the group and module information are the same for each dependency. If they are brought as different dependencies, it will result in duplicate class error.To test: