Show network error on connect site info error

wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android

GNU General Public License v2.0

14 stars 3 forks source link

Show network error on connect site info error #64

Closed malinajirka closed 2 years ago

malinajirka commented 2 years ago

Parent issue https://github.com/woocommerce/woocommerce-android/issues/3767

When connectSiteInfo request fails, the app runs a check and shows "no network" error when the device is offline. Previously it showed misleading “site URL entered is invalid” error)

To test: Test in WCAndroid - https://github.com/woocommerce/woocommerce-android/pull/4800

malinajirka commented 2 years ago

I'll be afk next week - please feel free to fix issues found during the review but also feel free to leave it up to me when I get back. Thanks 🙇

AnirudhBhat commented 2 years ago

@malinajirka Thanks for working on this! Changes looks good! :shipit: