search

wordpress-mobile / WordPress-Login-Flow-Android

Pluggable WordPress login flow for Android
GNU General Public License v2.0
14 stars 3 forks source link

Xmlrpc login errors. #78

Closed develric closed 2 years ago

develric commented 2 years ago

IMPORTANT: this is ready to be reviewed; but since it has implications for Woo as well, keeping it as a draft so it is not accidentally merged before the validation from WPAndroid and WooAndroid point of view.

This is part of https://github.com/wordpress-mobile/WordPress-Android/issues/12401.

I tried to keep the current behaviors for NON-SelfHosted sited not affected, only adding a couple of enums in FluxC mapping the various errors conditions for xml-rpc, that are used/parsed only in the login flow for now. This should reduce the possibility of regressions but appreciate testing of the various log-in/sign-up scenarios 🙇 .

See the https://github.com/wordpress-mobile/WordPress-Android/pull/15919 for more details.

hichamboushaba commented 2 years ago

I tested those changes with WCAndroid, and there is no regression, thanks @develric

khaykov commented 2 years ago

No changes since my review, so good to go as well 🚀