wordpress-mobile / WordPress-iOS-Shared

Shared components used in building the WordPress iOS apps and other library components
GNU General Public License v2.0
18 stars 22 forks source link

Fix pod lint warnings #145

Closed frosty closed 6 years ago

frosty commented 6 years ago

This PR fixes a warning that was being thrown when attempting to push a new pod release:

 -> WordPressShared (1.0.9)
    - WARN  | xcodebuild:  /Users/frosty/Library/Developer/Xcode/DerivedData/App-hcdcoxdssrhlaoeunehkzekojbln/Build/Products/Release-iphonesimulator/WordPressShared/WordPressShared.framework/Headers/WordPressShared-Swift.h:446:12: warning: parameter 'for' not found in the function declaration [-Wdocumentation]
    - NOTE  | xcodebuild:  /Users/frosty/Library/Developer/Xcode/DerivedData/App-hcdcoxdssrhlaoeunehkzekojbln/Build/Products/Release-iphonesimulator/WordPressShared/WordPressShared.framework/Headers/WordPressShared-Swift.h:446:12: note: did you mean 'style'?

[!] WordPressShared did not pass validation, due to 1 warning (but you can use `--allow-warnings` to ignore it).

The fix was simply to update the parameter name in a comment – we were using the external rather than internal parameter name.

To Test

frosty commented 6 years ago

Thanks for the review!