search

wordpress-mobile / WordPress-iOS-Shared

Shared components used in building the WordPress iOS apps and other library components
GNU General Public License v2.0
18 stars 22 forks source link

Adds URL validation as an extension to String. #199

Closed diegoreymendez closed 5 years ago

diegoreymendez commented 5 years ago

Description:

Adds URL validation as an extension to String.

This PR also adds unit tests although the project isn't configured to execute those tests unfortunately.

Testing:

This change was tested in a branch in WordPressAuthenticator. Unfortunately, I'm not aware of a way to run the unit tests currently.

I'll look into adding support for running our unit tests in a separate PR eventually (but I need to be able to deliver this even before that's ready).

Building this should be enough to at least know it's not breaking anything.

diegoreymendez commented 5 years ago

This is ready for review.

diegoreymendez commented 5 years ago

Thanks @jkmassel !

diegoreymendez commented 5 years ago

For context, this change is related to: https://github.com/wordpress-mobile/WordPress-iOS/issues/10294