search

wordpress-mobile / WordPress-iOS-Shared

Shared components used in building the WordPress iOS apps and other library components
GNU General Public License v2.0
18 stars 22 forks source link

Migrates some code to Swift. Strips Gutenberg galleries from summaries. #244

Closed diegoreymendez closed 4 years ago

diegoreymendez commented 4 years ago

Related to https://github.com/wordpress-mobile/WordPress-iOS/issues/13154

This PR improves the existing code, adds tests, and implements logic to strip Gutenberg Galleries from excerpts.

Changes:

Associated branches:

WordPress-iOS test branch: issue/13154-remove-gallery-captions-from-excerpts WordPress-Kit test branch: issue/wpios-13154-strip-gutenberg-galleries

Testing:

Test 1:

Run the unit tests.

Test 2:

Check out the associated branches and run the unit tests.

Test 3:

Run the WPiOS associated branch and follow the testing steps detailed in this issue: https://github.com/wordpress-mobile/WordPress-iOS/issues/13154

This is what you should see:

testingExcerpts