search

wordpress-mobile / WordPress-iOS-Shared

Shared components used in building the WordPress iOS apps and other library components
GNU General Public License v2.0
18 stars 22 forks source link

Remove event for tapping the mode button on the design view #309

Closed twstokes closed 2 years ago

twstokes commented 2 years ago

This PR removes the WPAnalyticsStatEnhancedSiteCreationSiteDesignThumbnailModeButtonTapped event and will target the feature branch feature/site-design-revamp.

ovitrif commented 2 years ago

@twstokes To double check, shouldn't the target branch for merging be feature/site-design-revamp instead of trunk 🤷 ?

twstokes commented 2 years ago

This looks good, nice work Tanner!

Thank you @mkevins for the view! 🙇

@twstokes To double check, shouldn't the target branch for merging be feature/site-design-revamp instead of trunk 🤷 ?

Great catch @ovitrif! I almost proceeded with merging this to trunk! 😬 You're exactly right, so I've updated the target branch. 🙇