wordpress-mobile / WordPress-iOS-Shared

Shared components used in building the WordPress iOS apps and other library components
GNU General Public License v2.0
18 stars 22 forks source link

Remove FormatterKit depencendency #318

Closed mokagio closed 1 year ago

mokagio commented 1 year ago

I just opened a PR on WordPress iOS that removes a usage of the deprecated mediumString(timeZone:) method, https://github.com/wordpress-mobile/WordPress-iOS/pull/19523.

That method was deprecated to remove our dependency on FormatterKit.

Together with mediumString(timeZone:), we also have pageSectionFormatter. which uses FormatterKit. On top of that, two versions of toStringForPageSections that seem to be unused.

I git greped for those strings in WordPress and WooCommerce iOS and did not find any match. We should be able to remove them and FormatterKit. This will require a new major version release, so we might take the occasion to review existing TODOs and other deprecations.

mokagio commented 1 year ago

Closed by #320.