wordpress-mobile / WordPress-iOS-Shared

Shared components used in building the WordPress iOS apps and other library components
GNU General Public License v2.0
18 stars 22 forks source link

Delete CocoaLumberjack #325

Closed crazytonyli closed 1 year ago

crazytonyli commented 1 year ago

The main purpose is removing CocoaLumberjack from all libraries(I'll be making similar PRs to WordPressKit and WordPressAuthenticator later), which will make the SPM support slightly easier and potentially solves some logging set up issues we are having on the app side.

A protocol WordPressLoggingDelegate (similar to tracks' TracksLoggingDelegate) is introduced in this PR. All the DDLogXxx calls are replaced with new WPSharedLog calls which uses the WordPressLoggingDelegate instance to do the actual logging. On the app side, we need to provide a implementation of this logging delegate protocol (like TracksLogger).