SIWA: Disconnecting SIWA on wpcom results in confusing push notification

wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository

http://ios.wordpress.org/

GNU General Public License v2.0

3.69k stars 1.12k forks source link

SIWA: Disconnecting SIWA on wpcom results in confusing push notification #12443

Open astralbodies opened 5 years ago

astralbodies commented 5 years ago

Title has it. This is probably a backend change, but I am logging here for visibility.

And the notification in the app showing the body:

Tug commented 5 years ago

@astralbodies Not sure what's wrong with it, what message would you expect to receive here instead? For reference, this was added by @belcherj for google sign in wpcom patch D24232. We could update the copy for apple to display Sign in with Apple instead if you think that's better

astralbodies commented 5 years ago

@Tug I'm not sure, really, except maybe "Access Removed" should be a part of the notification payload so the lock screen shows that bit as well.

ScoutHarris commented 5 years ago

Hey @Tug I'm not sure what happened with this, but I'm assigning this to you for follow up since it seems you can address it.

stale[bot] commented 4 years ago

This issue has been marked as stale because:

It has been inactive for the past year.
It isn't in a project or a milestone.
It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

aerych commented 3 years ago

Likely still an issue and I agree this is something most likely to be addressed server-side rather than in the app. Not sure this is strictly a bug but leaving the label for now

stale[bot] commented 2 years ago

This issue has been marked as stale because:

It has been inactive for the past year.
It isn't in a project or a milestone.
It hasn’t been labeled [Pri] Blocker, [Pri] High, or good first issue.

Please comment with an update if you believe this issue is still valid or if it can be closed. This issue will also be reviewed for validity and priority during regularly scheduled triage sessions.

salimbraksa commented 8 months ago

This issue remains in JPiOS 24.4

Steps to reproduce

Sign in to the Jetpack app using Sign In with Apple.
On WordPress.com, Disconnect the SIWA from within the account's social login page.
Observe if a notification similar to the one in the screenshot is received on Jetpack app.

dangermattic commented 8 months ago

Thanks for reporting! 👍