[VoiceOver] Media Library concerns

shiki commented 4 years ago

Media Library

~[A1] The Preview and Insert buttons should be visible but disabled by default~

~They are not discoverable if they are hidden until you select an image. It may be difficult for users to figure out how to interact with the UI.~

~The behavior of hiding and showing also interrupts with the scrolling dictation like:~

~1. Scroll down. ”Page 6 of 7”~ ~2. Scroll down. “Page 7 of 7”~ ~3. Select an image.~ ~4. Scroll up. “Page 7 of 8”.~

~The number of pages changed even though the data didn't change.~

~The buttons can also make use of .accessibilityValue if they don't have that already.~

[A2] Buttons are missing labels

[ ] The Cancel button shown after pressing Edit can probably be better labeled as “Cancel editing”.
[ ] The Trash button shown when editing doesn't have a label. VoiceOver just says “Dimmed. Button”

Media Library → Image Details

[ ] The Trash and Share button have no labels
[ ] The image has no .image trait

rohanrk commented 3 years ago

This is quite closely related to the PR I just put out. I'm happy to work on this once that PR is closed

shiki commented 3 years ago

@rohanrk Cool! I assigned you to the task. 🙂

rohanrk commented 3 years ago

Could I get some more info on the preview and insert buttons? I'm not quite sure what they refer to in this context. I think preview has to do with previewing selected images but this is handled through a long press rather than a button.

shiki commented 3 years ago

It looks like the UI has changed a bit and it's no longer possible to pick multiple images. I have crossed out the ones the issues that are no longer valid.

Sorry about that, @rohanrk!

wordpress-mobile / WordPress-iOS