wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.68k stars 1.12k forks source link

File Block looks unpolished in the Reader #15533

Open startuptester opened 3 years ago

startuptester commented 3 years ago

Expected behavior

In the Reader, File blocks should look similar to they do on my site IMG_1D187540CE79-1

Actual behavior

IMG_2D550EB66A69-1

Steps to reproduce the behavior

  1. Add a file block to a post
  2. View in Reader
Tested on iPad and iPhone 12 Pro, iOS 14.2, WPiOS 16.4.0.0
startuptester commented 3 years ago

@yaelirub this is not happening on the Reader in Android

Screenshot_20201217-111032_WordPress

But it IS happening on the web

Screen Shot 2020-12-17 at 11 13 42 AM

So I should report to Calypso and close this one? It doesn't make sense to me that it's working on Android and nowhere else, how can that happen?

emilylaguna commented 3 years ago

After a discussion with @leandroalonso about this issue today it looks like this is happening because iOS strips out the style attribute from the tags to prevent styling issues in reader.

Because of that, this issue is larger than originally anticipated and adding a local style for the button isn't the correct fix, and we should look further into changing how the reader parses the element styles to better support the work done.

leandroalonso commented 3 years ago

Just adding a little bit more info:

daniloercoli commented 7 months ago

Checked on Jetpack 24.2, and I can still reproduce the issue.