Contact us view doesn't respect Dark Mode

wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository

http://ios.wordpress.org/

GNU General Public License v2.0

3.69k stars 1.12k forks source link

Contact us view doesn't respect Dark Mode #17263

Open twstokes opened 3 years ago

twstokes commented 3 years ago

Expected behavior

The "Contact us" view should adapt to a color scheme suited for Dark Mode when in that mode.

Actual behavior

The "Contact us" view's color scheme doesn't adapt well to Dark Mode.

Steps to reproduce the behavior

On the "My Site" view, tap the Gravatar at the top right to load the "Me" view
Tap "Help & Support"
Tap "Contact Support"
Switch between Light and Dark mode to observe the behavior

Tested on iPhone 12 Pro, iOS 15.0.1, WPiOS 18.4

dcalhoun commented 3 years ago

Counter to the Android SDK, I was unable to find Zendesk iOS SDK documentation regarding Dark Mode support or customizing the look.

ScoutHarris commented 3 years ago

I wouldn't qualify this as a bug really. We're simply using the view that is displayed by the Zendesk SDK, and it was decided during initial implementation not to customize these views.

Having said that, per the Zendesk documentation it looks like maybe some of the colors can be customized via their CommonUISDK. Sadly the documentation is very limited, and I tried their example and exactly nothing changed. 🤷 It may take some fiddling / more investigation to get the colors to change. Anyway, I've changed the type to Enhancement. May be a good hack week project?

twstokes commented 2 years ago

Sounds good @ScoutHarris, I've updated the Android ticket to match.

sla8c commented 2 years ago

I've taken a look at this during hackweek and the SDK still doesn't support dark mode.

Rollup of what I've done:

I cloned the Zendesk iOS SDK latest GitHub samples SDKs
had a scour to see if DarkMode was supported + went through their API docs
Tried a few light "hacks" to see if say setting dark mode on the Zendesk ViewController / Views as well as their Parents would override DarkMode (this didn't work either)
I tried the CommonUISDK as well and tried to fiddle with this hoping a more recent update might have fixed this issue however only the Send Button reflects any change
I've posted on the Zendesk community website to try to bring this to their attention; link is here

twstokes commented 2 years ago

Thanks @sla8c for investigating this! 🙇

twstokes commented 2 years ago

Zendesk's response:

Hi Steve,

I'm afraid that the Support SDK for iOS does not support dark, and we're unlikely to add this to the Support SDK in the future. Later generation SDKs, such as the Zendesk SDK for messaging fully supports dark more out of the box however.

It sounds like it'll take an SDK upgrade to support this.

sla8c commented 2 years ago

Thanks @twstokes - I saw that earlier + forgot to update within the issue. I'll un-assign myself in case anyone else wants to take a look in interim and I'll pick up again when I have time / next hack week 🙂

ScoutHarris commented 2 years ago

FWIW, Hummingbird has a support section improvements project in the backlog (dates TBD, but later this year). One of the stated goals is to address this issue, assuming it's still open when the project kicks off.

twstokes commented 2 years ago

One of the stated goals is to address this issue

Awesome! I was hoping that was the case @ScoutHarris, so thanks for confirming.