wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.66k stars 1.11k forks source link

Blogging Reminders: incorrect layout in landscape on iPhone plus #18193

Open ScoutHarris opened 2 years ago

ScoutHarris commented 2 years ago

Expected behavior

The view should render correctly in any orientation.

Actual behavior

On an iPhone plus, in landscape the view is unusable.

Steps to reproduce the behavior

On a plus size iPhone:

Portrait Landscape
portrait landscape
Tested on [iPhone 11 Pro Max], iOS [15.4], WPiOS [19.3]
guarani commented 2 years ago

Thanks for reporting this, @ScoutHarris!

I've assigned this Medium priority since doesn't affect portrait layout. However, as you mentioned to me offline, it affects your team's future modifications to this screen.

@frosty, do you know if this issue has been discussed previously?

ScoutHarris commented 2 years ago

Hey guys.

As I mentioned to @guarani , @wargcm is starting to add a new toggle to that view (#18316). My main concern is overlapping work causing conflicts. Maybe it would be best for Chris to add that toggle, then @frosty (or whoever) comes in afterwards to fix this?

guarani commented 2 years ago

That sounds like a good plan. Since the screen appears to be working correctly in portrait, adding the toggle might be separate to the fix required for landscape mode. Thanks for reporting this ❤️. We'll follow up based on @frosty answer to the above.

frosty commented 2 years ago

Sorry I missed this ping! We've discussed in #p2-pbArwn-4in that this screen ideally needs to be adjusted to be wrapped in a scrollview to allow longer content to fit and scroll.

ScoutHarris commented 2 years ago

Just to cross-reference - this PR removes the Tip section. It probably should be added back once the view is refactored.

guarani commented 2 years ago

Thanks @frosty and @ScoutHarris!

It probably should be added back once the view is refactored.

Based on the latest discussion here, the tip's removal might be permanent, but that's a different topic.

Thanks for removing it, @ScoutHarris 👍