search

wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.69k stars 1.12k forks source link

Remove Google Plus mentions #20142

Open mokagio opened 1 year ago

mokagio commented 1 year ago

I've come across a few mentions of the defunct Google Plus service between this codebase and WordPressKit.

image

We should remove them.

At least one seems to be a workaround to hide Google Plus related content, so this could be a good occasion to simplify the codebase as well.

peril-wordpress-mobile[bot] commented 1 year ago
Fails
:no_entry_sign: Please add a type label to this issue. e.g. '[Type] Enhancement'

Generated by :no_entry_sign: dangerJS

chriswebb09 commented 1 year ago

Hi @mokagio 🤚 Can I work on this issue?

mokagio commented 1 year ago

Sure thing @chriswebb09 🙇‍♂️ We are always happy and thankful when community members submit pull requests.

harsitagarwalla187 commented 1 year ago

@mokagio Can I work in this if @chriswebb09 not working in it.

chriswebb09 commented 1 year ago

@harsitagarwalla187 I'm working on it.

mokagio commented 1 year ago

Thank you anyways @harsitagarwalla187 🙇‍♂️

@chriswebb09 great to hear you're looking at this. I personally find that small PRs are easier to review and have higher likelihood of being merged, so feel free to open a PR even just for removing some of the mentions.

Thanks!

chriswebb09 commented 1 year ago

@mokagio gotcha, appreciate the pointers! I'll try to have some out today!

chriswebb09 commented 1 year ago

@mokagio I have a PR ready, the unit test suite on iOS appear to be failing for an unrelated unrelated issue in the Automattic-Tracks-iOS pod (force unwrapping in LogEncryptor.swift) Is this expected? Additionally I've changed PublicizeService which is a NSManagedObject subclass, are there any additional considerations / tests / migrations for CoreData that I should be considering?

mokagio commented 1 year ago

@chriswebb09 thank you for the ping! I think it would be easiest to answer your question with a PR already open so we can look at the code. Do you mind doing that and dropping a link to it here? Thanks!

chriswebb09 commented 1 year ago

@mokagio Thanks! Here you go: https://github.com/wordpress-mobile/WordPress-iOS/pull/20664