wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.7k stars 1.12k forks source link

Add Interactive Comment Notifications for iOS 8 #2036

Closed roundhill closed 7 years ago

roundhill commented 10 years ago

For comment notifications, we should add:

sendhil commented 10 years ago

Reply button if the user can reply. This will load the comment detail view when tapped?

Would it be possible to reply inline?

Moderation buttons based on the current comment status. We may be limited to the amount of buttons we can add so maybe one button for Approve/Unapprove. Don't show this button if the user can't moderate. This will also be a background action.

I think can get a few options in there, here's a screenshot from the notifications talk: image

roundhill commented 10 years ago

Would it be possible to reply inline?

I watched a WWDC video on notifications and they didn't touch on that... but let's hope.

roundhill commented 10 years ago

I think can get a few options in there, here's a screenshot from the notifications talk:

Unfortunately that's only with the alert view style, I think. But yeah we can add lots of options there.

jleandroperez commented 9 years ago

Problem with this issue is that Interactive Notifications don't require any kind of authentication.

We've been discussing this in the WordPress slack, and @astralbodies pointed out it'd be a good idea to also provide an opt-out setting.

That way, you could prevent anyone that picked up your phone from replying, without unlocking the phone first.

koke commented 9 years ago

Problem with this issue is that Interactive Notifications don't require any kind of authentication

Replying to a message doesn't require authentication but archiving an email asks for TouchID/passcode

rich-notification-auth

jleandroperez commented 9 years ago

@koke try the same with SMS's. You'll get the Reply button, even when logged out (deauthenticated!)

koke commented 9 years ago

If you set the action’s authenticationRequired property to YES and the device is locked when the user responds to the notification, the user must enter a passcode when choosing the action. However, this does not unlock the device, so if your app needs to access files, make sure the files are in the right data protection class. When the value of the activationMode property is UIUserNotificationActivationModeForeground, the value of the authenticationRequired property is assumed to be YES regardless of its actual value.

https://developer.apple.com/library/mac/documentation/NetworkingInternet/Conceptual/RemoteNotificationsPG/Chapters/IPhoneOSClientImp.html#//apple_ref/doc/uid/TP40008194-CH103-SW26

jleandroperez commented 9 years ago

@koke awesome! all concerns cleared then, this issue has a green light.

Thank you!

jleandroperez commented 9 years ago

Update:

iOS 9 adds support for Text Input UIUserNotificationActions. Let's implement this as soon as we switch to Xcode 7 GM!

koke commented 7 years ago

Is there something else to do here? It looks like this is implemented, although we could add a few more actions (e.g. spam/trash for comments)

jleandroperez commented 7 years ago

@koke actually... we do support Replying to comments, but that action ends up opening the app.

This issue was intended to add actual "Inline Reply" support (pretty much like iMsg / Whatsapp, when you force press an incoming message, within the lock screen).

koke commented 7 years ago

Gotcha, I think I'll create a separate issue to make that clearer :)

jleandroperez commented 7 years ago

Awesome, thank you sir!