wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.68k stars 1.11k forks source link

Simplify navigating to the Notifications tab #23570

Closed crazytonyli closed 1 month ago

crazytonyli commented 1 month ago

This PR moves a few functions from the RootViewPresenter protocol definition to its extension, so that we can have one implementation to be shared by different conformations.

There should be no changes to how the app behaves. You can test the changes by using the following universal links:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

wpmobilebot commented 1 month ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23570-e89fbad
Version25.3
Bundle IDcom.jetpack.alpha
Commite89fbad9b6621a1baa1a349101836682a99c1a40
App Center Buildjetpack-installable-builds #9658
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 month ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23570-e89fbad
Version25.3
Bundle IDorg.wordpress.alpha
Commite89fbad9b6621a1baa1a349101836682a99c1a40
App Center BuildWPiOS - One-Offs #10615
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.