wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.68k stars 1.11k forks source link

Sidebar: Reader selection #23577

Closed kean closed 4 weeks ago

kean commented 4 weeks ago

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

wpmobilebot commented 4 weeks ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23577-a9c21ff
Version25.3
Bundle IDorg.wordpress.alpha
Commita9c21ff489c82134455471ddbb43153fbb72e071
App Center BuildWPiOS - One-Offs #10629
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 4 weeks ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23577-a9c21ff
Version25.3
Bundle IDcom.jetpack.alpha
Commita9c21ff489c82134455471ddbb43153fbb72e071
App Center Buildjetpack-installable-builds #9672
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
crazytonyli commented 4 weeks ago

This should just work with the changes in https://github.com/wordpress-mobile/WordPress-iOS/pull/23578, within one app launch session.

I don't feel it's necessary to persist Recent or Discover selection to disk, so that the selection carries over to the next app launch?

kean commented 4 weeks ago

I don't feel it's necessary to persist Recent or Discover selection to disk, so that the selection carries over to the next app launch?

I think it is an existing features, but I'm not really sure why. It is a bit harder to switch modes using the "pill" as it tapes a tap, an animation, and another tap.

crazytonyli commented 4 weeks ago

I think it is an existing features, but I'm not really sure why.

Oh, I didn't notice that. I wonder if that plays a factor in the new design's lower engagement. All selection are saved across sessions. If the apps stays in "Likes" or any particular list, the posts there would be updated much less frequently than "Discover".

kean commented 4 weeks ago

I don't think it needs to save the selection if you are in "Saved", "Likes", "Search", "Subscriptions" or any of the individual feeds. If you close the app after finishing with one of these screens, would you expect to be automatically returned to your previous selection when re-opening the app? I would probably say no, especially if a significant amount of time passes between sessions.

However, I can see some folks preferring "Discover" over "Recent", so it's probably worth saving the selection. It definitely wouldn't hurt as it's unlikely anyone will be confused when they land on "Discover" over "Recent" if that's where they closed the app.