Sidebar: Show Site Settings in modal on iPad

kean commented 4 weeks ago

The app will now show "Site Settings" in a form modal like all other "Settings" pages.

There are multiple advantages to showing it in a modal:

It makes sure all sub-screens look great, even if they are not designed yet to support readable content guide like "Site Privacy"
It puts you into context. This looks disorienting:

To test:

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding unit tests for my changes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] VoiceOver.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] iPhone and iPad.
[ ] Multi-tasking: Split view and Slide over. (iPad)

wpmobilebot commented 4 weeks ago

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot commented 4 weeks ago

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.