Sidebar: Global Reader Navigation

[kean]

Reader required similar design as BlogDetailsSubsection for representing its paths, so I added ReaderNavigationPath:

enum ReaderNavigationPath: Hashable {
    case discover
    // ...
}

// In RootViewPresenter
func showReader(path: ReaderNavigationPath?)

Every single Reader navigation is now handled by this one method.

Changes

Unlike the previous PR, I won't cover every change because most of it is just moving code around. But here are some of the more important ones:

• https://github.com/wordpress-mobile/WordPress-iOS/pull/23605/commits/6454b2e53769a16a9ee2824e4fa2048c92ec76c2 adds ReaderNavigationPath initially only for .discover. Here it is in action (invoked programmatically): iPhone, iPad, iPad Split View, iPad link from Insights
• https://github.com/wordpress-mobile/WordPress-iOS/pull/23605/commits/3a0c7b709f5aeea839fbb78d346cded71651b20b adds ReaderNavigationPath.post(postID:siteID:). Recording: iPhone and iPad.
• https://github.com/wordpress-mobile/WordPress-iOS/pull/23605/commits/97fafef42674e3ba48fef7f6bb1b74022d2e59bc replaces navigateToReader site and brings us closer to removing ReaderCoordinator. I wanted to note that it fetches the topics are fetched async when using deep links. It seems to work OK in practice, but it's not great. Recording: iPad, Split View
• https://github.com/wordpress-mobile/WordPress-iOS/pull/23605/commits/057dc5f8090a861ada17580fa820438dab0f34f5 adds the link to subscriptions and fixes part of this issue I found – it now opens "Manage" instead of just your subscriptions: recording.
• https://github.com/wordpress-mobile/WordPress-iOS/pull/23605/commits/83e166eedf354b5ab627866658caf773eb5f5991 removes switchToTopic(where:). For simplicity, for deep links it will replace the .secondary column but won't show any selection in the sidebar, which I think is completely acceptable. It might be improved in the future Reader project.
• https://github.com/wordpress-mobile/WordPress-iOS/pull/23605/commits/69f521f48483c8f02b4cb9ddb64b80af692c5f83 finally removes ReaderCoordinator 🥳

To test:

• Follow the steps from the videos

Regression Notes

1. Potential unintended areas of impact

2. What I did to test those areas of impact (or what existing automated tests I relied on)

3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

• [ ] I have completed the Regression Notes.
• [ ] I have considered adding unit tests for my changes.
• [ ] I have considered adding accessibility improvements for my changes.
• [ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

• [ ] WordPress.com sites and self-hosted Jetpack sites.
• [ ] Portrait and landscape orientations.
• [ ] Light and dark modes.
• [ ] Fonts: Larger, smaller and bold text.
• [ ] High contrast.
• [ ] VoiceOver.
• [ ] Languages with large words or with letters/accents not frequently used in English.
• [ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
• [ ] iPhone and iPad.
• [ ] Multi-tasking: Split view and Slide over. (iPad)

[dangermattic]

	2 Warnings
:warning:	This PR is larger than 500 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.
:warning:	This PR is assigned to the milestone 25.4. This milestone is due in less than 4 days. Please make sure to get it merged by then or assign it to a milestone with a later deadline.

Generated by :no_entry_sign: Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23605-2b1ff18
	Version	25.3
	Bundle ID	com.jetpack.alpha
	Commit	2b1ff18a4580412199aba8be0877eccfc8c7b962
	App Center Build	jetpack-installable-builds #9744

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

[wpmobilebot]

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23605-2b1ff18
	Version	25.3
	Bundle ID	org.wordpress.alpha
	Commit	2b1ff18a4580412199aba8be0877eccfc8c7b962
	App Center Build	WPiOS - One-Offs #10700

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.