wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.7k stars 1.12k forks source link

Sidebar: Enable FF #23617

Closed kean closed 1 month ago

kean commented 1 month ago

Enable FF for production.

To test:

Regression Notes

  1. Potential unintended areas of impact

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

Testing checklist:

dangermattic commented 1 month ago
1 Warning
:warning: This PR is assigned to the milestone 25.4. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by :no_entry_sign: Danger

wpmobilebot commented 1 month ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23617-9d94244
Version25.3
Bundle IDcom.jetpack.alpha
Commit9d942440a21dee754d94683cfd1055816d02697f
App Center Buildjetpack-installable-builds #9761
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 1 month ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23617-9d94244
Version25.3
Bundle IDorg.wordpress.alpha
Commit9d942440a21dee754d94683cfd1055816d02697f
App Center BuildWPiOS - One-Offs #10718
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
kean commented 1 month ago

"UI Tests (iPad): 29 tests have failed (29 distinct assertion failure(s) in total)" I need to update them all 😞

kean commented 1 month ago

It's probably best to fix UI tests sooner rather than later. Otherwise, the UI test runs on PR would waste time on testing the wrong things.

I don't know if we have the capacity to maintain tests on iPad. I guess it shouldn't be too hard to update, but it always take me way to much time to change and test anything there.