wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository
http://ios.wordpress.org/
GNU General Public License v2.0
3.66k stars 1.11k forks source link

feat: Handle remote editor load failure #23624

Open dcalhoun opened 3 days ago

dcalhoun commented 3 days ago

Description

Gracefully handle failed attempts to load a site's remote editor by falling back to the local, default editor and displaying a notice to the user.

Related:

To test: See https://github.com/wordpress-mobile/GutenbergKit/pull/27.

Regression Notes

  1. Potential unintended areas of impact None, should be limited to the experimental editor.
  2. What I did to test those areas of impact (or what existing automated tests I relied on) N/A.
  3. What automated tests I added (or what prevented me from doing so) None, we are not focused on automating tests for this experimental feature.

PR submission checklist:

Testing checklist:

dangermattic commented 3 days ago
2 Warnings
:warning: Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages in Xcode.
:warning: PR is not assigned to a milestone.

Generated by :no_entry_sign: Danger

wpmobilebot commented 3 days ago
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23624-40efb07
Version25.3
Bundle IDcom.jetpack.alpha
Commit40efb0776ae71f284cce364f1a5de4baac6fcb0b
App Center Buildjetpack-installable-builds #9777
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.
wpmobilebot commented 3 days ago
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23624-40efb07
Version25.3
Bundle IDorg.wordpress.alpha
Commit40efb0776ae71f284cce364f1a5de4baac6fcb0b
App Center BuildWPiOS - One-Offs #10733
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.