Closed mrpolanco closed 1 week ago
Hey, thanks for addressing it, @mrpolanco.
For localization, developers usually add a key with a default localization (English) and let the translators update it for other languages. I would suggest the following changes:
private enum Strings {
static let details = NSLocalizedString(key: "twoFactorAuthorization.details", value: "Please enter the verification code from your authentication app for your WordPress.com account.", comment: "The details label in the two-factor authorization screen. Note: it has to mention that it's for a WordPress.com account")
}
You can use the comment to clarify how it is used and what it should contain. See other files for reference.
Hi @kean ! Thank you for the feedback. I undid the localizable.string
changes and submitted the change only to NSLocalizedString(), as indicated. But I fear I may have updated it incorrectly - my apologies. Please let me know if I can correct on my end.
New PR here @kean : https://github.com/wordpress-mobile/WordPress-iOS/pull/23645
Fixes #21875
Added clarity to the verification code view that the code is for WordPress.com:
Localization strings edited, and added to missing language (Czech).
To test:
Regression Notes
Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so) None
PR submission checklist:
[ ] I have completed the Regression Notes.
[ ] I have considered adding unit tests for my changes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to
RELEASE-NOTES.txt
if necessary.Testing checklist: