Minor update to the log functions API - Githubissues

wordpress-mobile / WordPress-iOS

WordPress for iOS - Official repository

http://ios.wordpress.org/

GNU General Public License v2.0

3.68k stars 1.11k forks source link

Minor update to the log functions API #23637

Closed crazytonyli closed 1 week ago

crazytonyli commented 1 week ago

Simple and boring changes to make the DDLogXxx functions in the app target match the ones in CocoaLumberjack.

The first comment is the main changes. The second commit is just changing DDLog(aString) to DDLog("\(aString)") to make compiler happy.

Regression Notes

Potential unintended areas of impact
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)

PR submission checklist:

[ ] I have completed the Regression Notes.
[ ] I have considered adding unit tests for my changes.
[ ] I have considered adding accessibility improvements for my changes.
[ ] I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

[ ] WordPress.com sites and self-hosted Jetpack sites.
[ ] Portrait and landscape orientations.
[ ] Light and dark modes.
[ ] Fonts: Larger, smaller and bold text.
[ ] High contrast.
[ ] VoiceOver.
[ ] Languages with large words or with letters/accents not frequently used in English.
[ ] Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
[ ] iPhone and iPad.
[ ] Multi-tasking: Split view and Slide over. (iPad)

wpmobilebot commented 1 week ago

WordPress Alpha

📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.

	App Name	WordPress Alpha
	Configuration	Release-Alpha
	Build Number	pr23637-de27e80
	Version	25.4
	Bundle ID	org.wordpress.alpha
	Commit	de27e80a96a071d4d1e3467cb7a87a91d5aa2ded
	App Center Build	WPiOS - One-Offs #10770

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

wpmobilebot commented 1 week ago

Jetpack Alpha

📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.

	App Name	Jetpack Alpha
	Configuration	Release-Alpha
	Build Number	pr23637-de27e80
	Version	25.4
	Bundle ID	com.jetpack.alpha
	Commit	de27e80a96a071d4d1e3467cb7a87a91d5aa2ded
	App Center Build	jetpack-installable-builds #9812

Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.